Ubuntu UI Toolkit

Merge lp://qastaging/~zsombi/ubuntu-ui-toolkit/thindivider-fix into lp://qastaging/ubuntu-ui-toolkit/staging

thindivider-fix
Merge into staging

Proposed by Zsombor Egri on 2014-08-26

Status:	Merged
Approved by:	Cris Dywan on 2014-08-27
Approved revision:	1220
Merged at revision:	1223
Proposed branch:	lp://qastaging/~zsombi/ubuntu-ui-toolkit/thindivider-fix
Merge into:	lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target:	45 lines (+13/-2) 2 files modified components.api (+1/-0) modules/Ubuntu/Components/ListItems/ThinDivider.qml (+12/-2)
To merge this branch:	bzr merge lp://qastaging/~zsombi/ubuntu-ui-toolkit/thindivider-fix
Related bugs:	Link a bug report
Related blueprints:	SDK: Design a new ListItem and layouts (Undefined)

Reviewer	Review Type	Date Requested	Status
Cris Dywan		2014-08-26	Approve on 2014-08-27
PS Jenkins bot	continuous-integration		Approve on 2014-08-26
Review via email: mp+232227@code.qastaging.launchpad.net

Commit message

Thin divider adjustments.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-26:

PASSED: Continuous integration, rev:1219
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/913/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/745
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/745
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/745/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/745

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/913/rebuild

review: Approve (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2014-08-26:

This shouldn't be a public property. Please move it into a QtObject { id: internal }

review: Needs Fixing

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-08-27:

> This shouldn't be a public property. Please move it into a QtObject { id:
> internal }

It could be placed in an internal QtObject, but that would decrease the performance of the list item is used in. That's why I had chosen a private property, and also not to make the design with two rectangles but a 4step gradient.

lp://qastaging/~zsombi/ubuntu-ui-toolkit/thindivider-fix updated on 2014-08-27