OpenStack Compute (nova)

Merge lp://qastaging/~zulcss/nova/nova-testsuite-fix into lp://qastaging/~openstack-ubuntu-testing/nova/grizzly

  1. nova-testsuite-fix
  2. Merge into grizzly
Proposed by Chuck Short
Status: Needs review
Proposed branch: lp://qastaging/~zulcss/nova/nova-testsuite-fix
Merge into: lp://qastaging/~openstack-ubuntu-testing/nova/grizzly
Diff against target: 46 lines (+23/-0)
3 files modified
debian/changelog (+2/-0)
debian/patches/fail-tests-check.patch (+20/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~zulcss/nova/nova-testsuite-fix
Reviewer Review Type Date Requested Status
Openstack Ubuntu Testers Pending
Review via email: mp+137652@code.qastaging.launchpad.net

Description of the change

Currently the package builds succesfully, even when the testsuite fails. This patch modifies the run_test.sh to ftbfs the package when the tests fail.

To post a comment you must log in.
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

This looks okay, but I'm wondering if scraping logs is the best way to detect failures, or if it should rely on the RC from nose, similar to how the other projects currently run_tests: http://paste.ubuntu.com/1408568/

Also, this should really be fixed upstream to avoid another patch.

Reply
Revision history for this message
Chuck Short (zulcss) wrote :

Well the correct fix would probably use something like tox

Reply

Unmerged revisions

506. By Chuck Short

debian/patches/fail-tests-check.patch: Don't silently ignore tests
failing when building the package.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches