Merge lp://qastaging/~zulcss/python-novaclient/pbr-ftbfs into lp://qastaging/~openstack-ubuntu-testing/python-novaclient/havana
Proposed by
Chuck Short
| Status: | Merged |
|---|---|
| Approved by: | Yolanda Robla |
| Approved revision: | 70 |
| Merged at revision: | 70 |
| Proposed branch: | lp://qastaging/~zulcss/python-novaclient/pbr-ftbfs |
| Merge into: | lp://qastaging/~openstack-ubuntu-testing/python-novaclient/havana |
| Diff against target: |
131 lines (+63/-24) 5 files modified
debian/changelog (+10/-0) debian/control (+26/-23) debian/patches/series (+1/-0) debian/patches/skip-failing-test.patch (+25/-0) debian/rules (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~zulcss/python-novaclient/pbr-ftbfs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Yolanda Robla (community) | Approve | ||
| James Page | Needs Fixing | ||
|
Review via email:
|
|||
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
29 + python-testtools,
30 + python-pbr,
31 + python-d2to1,
32 + python-testtools,
33 + testrepository
You have python-testtools in twice - maybe wrap-and-sort -s would help with this type of dupe.
One other minor niggle - changelog lines can be up to 80 chars - I'd probably use a bit more of that :-)
Cheers
James