Checkbox

Merge lp://qastaging/~zyga/checkbox/bulk-override-api into lp://qastaging/checkbox

bulk-override-api
Merge into trunk

Proposed by Zygmunt Krynicki on 2015-02-24

Status:	Rejected
Rejected by:	Zygmunt Krynicki on 2015-02-25
Proposed branch:	lp://qastaging/~zyga/checkbox/bulk-override-api
Merge into:	lp://qastaging/checkbox
Diff against target:	1010 lines (+405/-88) 18 files modified checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml (+2/-2) checkbox-gui/gui-engine/gui-engine.cpp (+2/-0) checkbox-ng/checkbox_ng/service.py (+13/-1) live-test (+3/-0) plainbox/plainbox/impl/commands/inv_run.py (+9/-1) plainbox/plainbox/impl/pod.py (+45/-3) plainbox/plainbox/impl/providers/stubbox/units/testplans/all.pxu (+66/-0) plainbox/plainbox/impl/secure/providers/v1.py (+0/-1) plainbox/plainbox/impl/secure/qualifiers.py (+7/-1) plainbox/plainbox/impl/session/jobs.py (+49/-0) plainbox/plainbox/impl/session/manager.py (+73/-57) plainbox/plainbox/impl/session/state.py (+91/-3) plainbox/plainbox/impl/session/test_jobs.py (+8/-1) plainbox/plainbox/impl/session/test_manager.py (+16/-3) plainbox/plainbox/impl/session/test_state.py (+9/-4) plainbox/plainbox/impl/unit/testplan.py (+9/-3) plainbox/plainbox/vendor/morris/__init__.py (+0/-6) providers/plainbox-provider-checkbox/bin/optical_write_test (+3/-2)
To merge this branch:	bzr merge lp://qastaging/~zyga/checkbox/bulk-override-api
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Checkbox Developers		2015-02-24	Pending
Review via email: mp+250781@code.qastaging.launchpad.net

Description of the change

Hey.

This is one of the last branches in the CEP-8 story. It's NOT MEANT FOR LANDING

NOT MEANT FOR LANDING

So now that's out of the way, I need feedback on the code in this branch. I gave it some manual testing and it's a progressive build upon what we've been adding lately. There are two bugfixes here that affect just the weird test plan I've added to stubbox, some odd commit that belongs in a different branch here and there. The rest are the new features.

Commits have poor messages (short) and I'll expand on them. Some things that deserve automatic tests have none. Some things may use a docstring or two. I'll be working on addressing those today and tomorrow.

The base feature now works and "plainbox run" was patched to use it.

For testing have a look at those two commands:

The flashy one is:
stubbox -P -v run -T 2013.com.canonical.plainbox::cert-status-override/plan -f html -p with-certification-status -o demo.html

The informative one is:
stubbox -P -v run -T 2013.com.canonical.plainbox::cert-status-override/plan -f json -p with-certification-status

The full list of patches is:

c87cde5 support: add live-test
b1b2d63 plainbox:vendor:morris: remove signal.__{set,delete}__
8f10cb3 plainbox:pod: dedent Field.doc
74da3ef plainbox:pod: add Field(notify_fn=...)
5d699eb plainbox:pod: add unique_elements_assign_filter() aka unique()
91a2b2d plainbox:secure:qualifiers: fix select_jobs()
5da1d79 plainbox:unit:testplan: give less incorrect advice for pattern validation
7f1b8ac plainbox:unit:testplan: fix TestPlanSupport parse errors on missing values
b8cbd92 plainbox:session: add JobState.apply_overrides()
618aff6 plainbox:session: enable doctests for 'state'
33de438 plainbox:session: bump copyright
bb33391 plainbox:session: add SessionDeviceContext.override_map and friends
35c75fc plainbox:session: add note about complexity
74193f8 plainbox:session: don't use private SessionManager APIs
ad4eb95 plainbox:session: mock SessionStorage.create() return type
2290f77 plainbox:session: remove unused import
69983a7 plainbox:session: convert WellKnownDirsHelper to a POD
9114d86 plainbox:session: convert SessionManager to a POD
528237a plainbox:session: correct SessionManager.device_context_list docstring
babb3f1 plainbox:session: add SessionManager.test_plans
d31f451 plainbox:session: propagate SessionManager.test_plans changes to devices
d7423c4 plainbox:session: neuter '_propagate_test_plans' for testing
d714399 plainbox:session: mock-away SessionDeviceContext for create_with_state()
c1cdcc2 stubbox: add test data for certification-status feature
513d688 plainbox:commands:run: fix PEP-8 issue
ea03682 plainbox:commands:run: store selected test plan in SessionManager.test_plans
94cd8df plainbox:commands:run fixup

Revision history for this message

Sylvain Pineau (sylvain-pineau) wrote on 2015-02-24:

xlsx exporter works using:

stubbox -P -v run -T 2013.com.canonical.plainbox::cert-status-override/plan -f xlsx -o /tmp/foo.xlsx -p with-unit-categories

The result: http://people.canonical.com/~spineau/foo.xlsx

lp://qastaging/~zyga/checkbox/bulk-override-api updated on 2015-02-24

3591. By Zygmunt Krynicki on 2015-02-24

providers:checkbox: pass -input-charset to genisoimage