Merge lp://qastaging/~zyga/checkbox/checkbox-packaging into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Sylvain Pineau
Approved revision: no longer in the source branch.
Merged at revision: 33
Proposed branch: lp://qastaging/~zyga/checkbox/checkbox-packaging
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 53 lines (+19/-6)
3 files modified
debian/changelog (+6/-1)
debian/checkbox-ng-service.install (+1/-1)
debian/control (+12/-4)
To merge this branch: bzr merge lp://qastaging/~zyga/checkbox/checkbox-packaging
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+194098@code.qastaging.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

You could make the transition packages deborphan compliant.
It is recommended to adjust its section to oldlibs and its priority to extra in order to ease deborphan's job.

See: http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-transition

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Thanks, I didn't know about that.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Corrected

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Perfect, It's time to approve both branches now.

review: Approve
33. By Zygmunt Krynicki

"automatic merge by tarmac [r=sylvain-pineau][bug=][author=zkrynicki]"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches