Merge lp://qastaging/~zyga/checkbox/fix-1306051 into lp://qastaging/checkbox

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2909
Merged at revision: 2910
Proposed branch: lp://qastaging/~zyga/checkbox/fix-1306051
Merge into: lp://qastaging/checkbox
Diff against target: 21 lines (+4/-1)
1 file modified
plainbox/plainbox/provider_manager.py (+4/-1)
To merge this branch: bzr merge lp://qastaging/~zyga/checkbox/fix-1306051
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+215245@code.qastaging.launchpad.net

Description of the change

8afe5b7 plainbox:provider_manager: don't create bin/ blindly

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, easy enough. No tests:

12:32 < zyga> roadmr: there are no tests as provider_manager has no unit tests and clearly
              has not enough intergration tests to make that change matter
12:32 < zyga> roadmr: I thought about adding more but I need to refactor some code first,
              to make creating testbeds like that easier

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches