Checkbox

Merge lp://qastaging/~zyga/checkbox/fix-1312650 into lp://qastaging/checkbox

  1. fix-1312650
  2. Merge into trunk
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2962
Merged at revision: 2962
Proposed branch: lp://qastaging/~zyga/checkbox/fix-1312650
Merge into: lp://qastaging/checkbox
Diff against target: 72 lines (+21/-9)
2 files modified
plainbox/plainbox/impl/secure/plugins.py (+20/-8)
plainbox/plainbox/impl/secure/providers/v1.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~zyga/checkbox/fix-1312650
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+217827@code.qastaging.launchpad.net

Description of the change

cafeb69 plainbox:secure:plugins: add recursion support to FsPlugInCollection
9894cef plainbox:secure:providers: look for jobs recursively

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I think this *may* be broken (though it works in practice). Give me a sec

lp://qastaging/~zyga/checkbox/fix-1312650 updated
2961. By Zygmunt Krynicki

plainbox:secure:plugins: add recursion support to FsPlugInCollection

This patch changes FsPlugInCollection to support recursive search for
files in a directory. Recursive search can be enabled by using passing
recursive=True to the initializer. By default the old behavior is used.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2962. By Zygmunt Krynicki

plainbox:secure:providers: look for jobs recursively

Fixes: https://bugs.launchpad.net/plainbox/+bug/1312650

Signed-off-by: Zygmunt Krynicki <email address hidden>

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I fixed the thing that was broken now.

Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK, will make people's lives easier. Kudos for catching that obscure thing with os.path.join's behavior on absolute paths :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches