Merge lp://qastaging/~zyga/checkbox/fix-1318504 into lp://qastaging/checkbox
Proposed by
Zygmunt Krynicki
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 3031 |
| Merged at revision: | 3032 |
| Proposed branch: | lp://qastaging/~zyga/checkbox/fix-1318504 |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
224 lines (+81/-92) 1 file modified
checkbox-ng/checkbox_ng/service.py (+81/-92) |
| To merge this branch: | bzr merge lp://qastaging/~zyga/checkbox/fix-1318504 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FYI: I also tested that changing the lock to RLock (reentrant lock) has the same effect (the program works) and I checked which threads are used to call the callback. Everything looked as expected (reentrant locks removed the issue and the callback was always called from the registering thread) so I've decided to simply remove all of that locking