Checkbox

Merge lp://qastaging/~zyga/checkbox/fix-1323236 into lp://qastaging/checkbox

  1. fix-1323236
  2. Merge into trunk
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Ara Pulido
Approved revision: 3035
Merged at revision: 3035
Proposed branch: lp://qastaging/~zyga/checkbox/fix-1323236
Merge into: lp://qastaging/checkbox
Diff against target: 67 lines (+48/-7)
1 file modified
plainbox/plainbox/impl/exporter/xlsx.py (+48/-7)
To merge this branch: bzr merge lp://qastaging/~zyga/checkbox/fix-1323236
Reviewer Review Type Date Requested Status
Ara Pulido (community) Approve
Daniel Manrique (community) Approve
Review via email: mp+221245@code.qastaging.launchpad.net

Description of the change

db8aad9 plainbox:exporter:xlsx: more resilient bluetooth report

This is an alternative version of https://code.launchpad.net/~sylvain-pineau/checkbox/fix-1323236/+merge/221207 that should be more readable and maintainable over time. I hope.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK, the code is a bit more complex than the original but it should solve the problem.

review: Approve
Revision history for this message
Ara Pulido (ara) wrote :

That fixes the error for me.

review: Approve
Revision history for this message
Ara Pulido (ara) wrote :

Only BT devices appear in the XLS report

review: Needs Fixing
Revision history for this message
Ara Pulido (ara) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches