Checkbox

Merge lp://qastaging/~zyga/checkbox/fix-1325898 into lp://qastaging/checkbox

  1. fix-1325898
  2. Merge into trunk
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3050
Merged at revision: 3050
Proposed branch: lp://qastaging/~zyga/checkbox/fix-1325898
Merge into: lp://qastaging/checkbox
Diff against target: 54 lines (+14/-9)
1 file modified
plainbox/plainbox/impl/exporter/xlsx.py (+14/-9)
To merge this branch: bzr merge lp://qastaging/~zyga/checkbox/fix-1325898
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Zygmunt Krynicki (community) Needs Fixing
Review via email: mp+221858@code.qastaging.launchpad.net

Description of the change

55b5f29 plainbox:exporter:xlsx: fix division by zero

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

actually, that's wrong

review: Needs Fixing
lp://qastaging/~zyga/checkbox/fix-1325898 updated
3050. By Zygmunt Krynicki

plainbox:exporter:xlsx: fix division by zero

The xlsx exporter would crash if the total number of tests was zero so
let's handle that case.

https://bugs.launchpad.net/plainbox/+bug/1325898

Signed-off-by: Zygmunt Krynicki <email address hidden>

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Thanks for the fix. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches