Merge lp://qastaging/~zyga/checkbox/fix-1328903 into lp://qastaging/checkbox
Proposed by
Zygmunt Krynicki
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 3066 |
| Merged at revision: | 3066 |
| Proposed branch: | lp://qastaging/~zyga/checkbox/fix-1328903 |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
147 lines (+48/-8) 4 files modified
plainbox/plainbox/impl/ctrl.py (+9/-7) plainbox/plainbox/impl/test_ctrl.py (+14/-1) plainbox/plainbox/impl/unit/job.py (+13/-0) plainbox/plainbox/impl/unit/test_job.py (+12/-0) |
| To merge this branch: | bzr merge lp://qastaging/~zyga/checkbox/fix-1328903 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
7547a44 plainbox:unit:job: add JobDefinition.flags
e298a86 plainbox:unit:job: add JobDefinition.
3e24bd8 plainbox:ctrl: add support for 'preserve-locale' flag
c589d44 plainbox:ctrl: fix typo in a comment
To post a comment you must log in.
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
We need to document the new flags: field, and document possible values since this is handled magically in the code; otherwise this risks becoming an arcane feature nobody will be able to use (like environ: which is rather obscure).
But code-wise, this is OK, so let's go ahead.