Snapcraft

Merge lp://qastaging/~zyga/snapcraft/fix-1484596 into lp://qastaging/~snappy-dev/snapcraft/core

  1. fix-1484596
  2. Merge into core
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Daniel Holbach
Approved revision: no longer in the source branch.
Merged at revision: 200
Proposed branch: lp://qastaging/~zyga/snapcraft/fix-1484596
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 200 lines (+25/-0)
1 file modified
integration-tests/units/jobs.pxu (+25/-0)
To merge this branch: bzr merge lp://qastaging/~zyga/snapcraft/fix-1484596
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Leo Arias (community) Approve
Review via email: mp+271863@code.qastaging.launchpad.net

Commit message

Add 'simple' and 'has-leftovers' flags to all integration tests job units.

To post a comment you must log in.
lp://qastaging/~zyga/snapcraft/fix-1484596 updated
187. By Sergio Schvezov

Used builddir as a base for setup.py overrides by sergiusens approved by ted

Revision history for this message
Leo Arias (elopio) wrote :

Thanks zyga. I tested it with https://code.launchpad.net/~zyga/checkbox/fix-1484596/+merge/271890 and it works as promised.

Leaving my +1, waiting for the other branch to be released to top-approve.

review: Approve
lp://qastaging/~zyga/snapcraft/fix-1484596 updated
188. By Sergio Schvezov

Use relative paths for image creation by sergiusens approved by elopio

189. By Sergio Schvezov

Notify user why the password is being requested by sergiusens approved by elopio

190. By Sergio Schvezov

Load the config before trying to run by sergiusens approved by elopio

191. By Sergio Schvezov

Remove modules from plugins and infer it from the file name to follow the spec by sergiusens approved by elopio

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Just FYI I've also proposed https://code.launchpad.net/~zyga/checkbox/simple-jobs/+merge/271891 and when it lands all of the jobs can be simplified to have just three lines (at least).L

id: foo
command: blah
flags: simple

lp://qastaging/~zyga/snapcraft/fix-1484596 updated
192. By Sergio Schvezov

Enable ports for architectures that are not amd64 or i386 by sergiusens approved by ogra

193. By Sergio Schvezov

Local plugins as fallback instead of special casing to follow the spec by sergiusens approved by sergiusens,elopio

194. By Michael Vogt

Fetch all packages in a single download run with proper progress by mvo approved by dholbach

195. By Michael Vogt

stage package libgudev-1.0-0, which makes the godd snap actually work by dholbach approved by sergiusens

196. By Sergio Schvezov

Update docs to reflect list to dictionary change for services example by sergiusens approved by elopio

197. By Federico Gimenez

plainbox test for building the examples by fgimenez approved by dholbach

198. By Leo Arias

Fixed the python depends on the snapcraft-examples package. by elopio approved by sergiusens

199. By Ted Gould

Choose the python path based on the version installed by ted approved by sergiusens

Revision history for this message
Daniel Holbach (dholbach) wrote :

With the checkbox branch landed, does this MP need any update?

Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work!

review: Approve
lp://qastaging/~zyga/snapcraft/fix-1484596 updated
200. By Zygmunt Krynicki

Add 'simple' and 'has-leftovers' flags to all integration tests job units. by zyga approved by dholbach,elopio

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches