Code review comment for lp://qastaging/~3v1n0/bamf/lib-factory-xids-matching

Revision history for this message
Michal Hruby (mhr3) wrote :

It seems to be working fine, although it seems to be causing some assertions:

(bamfdaemon:26376): GLib-CRITICAL **: g_str_has_prefix: assertion `str != NULL' failed

Backtrace:

#0 g_log (log_domain=0x7ffff632370e "GLib", log_level=G_LOG_LEVEL_CRITICAL,
    format=0x7ffff632cb2a "%s: assertion `%s' failed")
    at /build/buildd/glib2.0-2.32.1/./glib/gmessages.c:788
#1 0x00007ffff63014f2 in g_str_has_prefix (str=0x0,
    prefix=0x43e931 "libreoffice")
    at /build/buildd/glib2.0-2.32.1/./glib/gstrfuncs.c:2771
#2 0x000000000042f265 in is_open_office_window (window=0x7ac1e0,
    self=<optimized out>)
    at /home/miso-work/unity/source/bamf/src/bamf-matcher.c:1378
#3 handle_window_opened (screen=<optimized out>, window=0x7ac1e0,
    self=0x7861b0) at /home/miso-work/unity/source/bamf/src/bamf-matcher.c:2081
#4 0x00007ffff67b6354 in g_cclosure_marshal_VOID__OBJECTv (closure=0x7b2630,
    return_value=<optimized out>, instance=0x777a80, args=<optimized out>,
    marshal_data=<optimized out>, n_params=<optimized out>,
    param_types=0x79bf50)
    at /build/buildd/glib2.0-2.32.1/./gobject/gmarshal.c:1312
#5 0x00007ffff67b2eca in _g_closure_invoke_va (closure=0x7b2630,
    return_value=0x0, instance=0x777a80, args=0x7fffffffd348, n_params=1,
    param_types=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./gobject/gclosure.c:840
#6 0x00007ffff67cb741 in g_signal_emit_valist (instance=0x777a80,
    signal_id=<optimized out>, detail=0, var_args=<optimized out>)
---Type <return> to continue, or q <return> to quit---
    at /build/buildd/glib2.0-2.32.1/./gobject/gsignal.c:3207
#7 0x00007ffff67cc242 in g_signal_emit (instance=<optimized out>,
    signal_id=<optimized out>, detail=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./gobject/gsignal.c:3352
#8 0x00007ffff67b6354 in g_cclosure_marshal_VOID__OBJECTv (closure=0x7b2590,
    return_value=<optimized out>, instance=0x79a390, args=<optimized out>,
    marshal_data=<optimized out>, n_params=<optimized out>,
    param_types=0x7b0f30)
    at /build/buildd/glib2.0-2.32.1/./gobject/gmarshal.c:1312
#9 0x00007ffff67b2eca in _g_closure_invoke_va (closure=0x7b2590,
    return_value=0x0, instance=0x79a390, args=0x7fffffffd718, n_params=1,
    param_types=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./gobject/gclosure.c:840
#10 0x00007ffff67cb741 in g_signal_emit_valist (instance=0x79a390,
    signal_id=<optimized out>, detail=0, var_args=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./gobject/gsignal.c:3207
#11 0x00007ffff67cc242 in g_signal_emit (instance=<optimized out>,
    signal_id=<optimized out>, detail=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./gobject/gsignal.c:3352
#12 0x00007ffff787e339 in ?? () from /usr/lib/libwnck-3.so.0
#13 0x00007ffff787ea24 in ?? () from /usr/lib/libwnck-3.so.0
#14 0x00007ffff62e4c9a in g_main_dispatch (context=0x666a80)
    at /build/buildd/glib2.0-2.32.1/./glib/gmain.c:2515
#15 g_main_context_dispatch (context=0x666a80)
    at /build/buildd/glib2.0-2.32.1/./glib/gmain.c:3052
#16 0x00007ffff62e5060 in g_main_context_iterate (dispatch=1,
    block=<optimized out>, context=0x666a80, self=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./glib/gmain.c:3123
#17 g_main_context_iterate (context=0x666a80, block=<optimized out>,
    dispatch=1, self=<optimized out>)
    at /build/buildd/glib2.0-2.32.1/./glib/gmain.c:3060
#18 0x00007ffff62e545a in g_main_loop_run (loop=0x78aa80)
    at /build/buildd/glib2.0-2.32.1/./glib/gmain.c:3317
#19 0x000000000041185e in main (argc=1, argv=0x7fffffffdb08)
    at /home/miso-work/unity/source/bamf/src/main.c:65

« Back to merge proposal