Code review comment for lp://qastaging/~3v1n0/libindicator/launch-shortucts-nicks-with-ctx

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> Thanks! This is definitely a change worth having in trunk as well.

Nice, for trunk I'd like to set the old one as deprecated though.
(or to be removed at all, since we're using it only in unity AFAIK)

> Just one problem: you renamed the original function to
> indicator_desktop_shortcuts_nick_exec_ctx. Probably by accident?

Ooops, sorry for this, fixed!

« Back to merge proposal