> Having indicator-object take care of this makes sense.
>
> In indicator_object_entry_being_removed() and
> indicator_object_entry_was_added(), the assignment to entry->parent_object
> should be unconditional and come before the "if (function_pointer != NULL)"
> blocks, just as the assignment to EntryPrivate's 'visibility' field is.
Yes, your're right, and it's what I did on first place (see the first commit), but this was breaking the tests.
Because in test_loader_filename_dummy_signaler you're actually setting the entry pointer value to a defined invalid value (5), and you're currently avoiding crashes only because some class functions are set to NULL.
So, I was just wondering what to do here... I'd prefer to change the test by the way.
> Having indicator-object take care of this makes sense. object_ entry_being_ removed( ) and object_ entry_was_ added() , the assignment to entry-> parent_ object
>
> In indicator_
> indicator_
> should be unconditional and come before the "if (function_pointer != NULL)"
> blocks, just as the assignment to EntryPrivate's 'visibility' field is.
Yes, your're right, and it's what I did on first place (see the first commit), but this was breaking the tests. filename_ dummy_signaler you're actually setting the entry pointer value to a defined invalid value (5), and you're currently avoiding crashes only because some class functions are set to NULL.
Because in test_loader_
So, I was just wondering what to do here... I'd prefer to change the test by the way.