Code review comment for lp://qastaging/~3v1n0/libindicator/reduce-image-serialization

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> Yeah, I'd love to have this as well, but some of the icons aren't square and
> need different rescaling.
>
> For example, this patch breaks indicator-power's icon. It's much smaller and
> blurry.

Well, not in unity [with lp:~3v1n0/unity/hidpi-better-scaling]... As we handle this thing at UI level (where it should be done imho), btw I've pushed also a change to the indicator-loader to show how to deal with this case.

I know it's something it would be nice to have at library level, but the gain in handling just image references is too high for us...
We could probably do the same thing I did here at unity-panel-service level (reading the "private" INDICATOR_NAMES_DATA, but I'd prefer to depend on an unstable data element like that).

« Back to merge proposal