Code review comment for lp://qastaging/~3v1n0/libindicator/reduce-image-serialization

Revision history for this message
Lars Karlitski (larsu) wrote :

> Well, not in unity [with lp:~3v1n0/unity/hidpi-better-scaling]... As we handle
> this thing at UI level (where it should be done imho), btw I've pushed also a
> change to the indicator-loader to show how to deal with this case.

I totally agree that this is where it should be handled. I didn't know you already fixed it. Nice work!

There's a bigger margin around the menu item in the loader now, but the size of the pixbuf seems to be correct. (Doesn't need to be fixed, I'm just mentioning it.)

I'm fine with landing this after the hidpi unity branch landed. Thanks!

review: Approve

« Back to merge proposal