Merge lp://qastaging/~3v1n0/notify-osd/fix-empty-newlines-appending into lp://qastaging/notify-osd

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: 507
Merged at revision: 505
Proposed branch: lp://qastaging/~3v1n0/notify-osd/fix-empty-newlines-appending
Merge into: lp://qastaging/notify-osd
Prerequisite: lp://qastaging/~3v1n0/notify-osd/fix-notifications-replacing
Diff against target: 75 lines (+37/-1)
3 files modified
debian/changelog (+7/-0)
src/bubble.c (+30/-0)
src/stack.c (+0/-1)
To merge this branch: bzr merge lp://qastaging/~3v1n0/notify-osd/fix-empty-newlines-appending
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+291964@code.qastaging.launchpad.net

Commit message

Bubble: don't append new lines when receiving empty bodies

Delay the addition of new lines until there's some real content to append.

Description of the change

To be tested with something like

from gi.repository import Notify
from time import sleep

Notify.init("Test App")

for i in range(10):
    n = Notify.Notification.new("Title", "" if i % 3 else "test {}".format(i))
    n.set_hint_string("append", "true")
    n.show()
    sleep(1)

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

review: Approve
508. By Marco Trevisan (Treviño)

Bubble: strip body text when adding it

509. By Marco Trevisan (Treviño)

Bubble: Indentation fixes

510. By Marco Trevisan (Treviño)

Merging changelog from landing silo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches