Ubuntu Settings Components

Code review comment for lp://qastaging/~3v1n0/ubuntu-settings-components/cmake-staging-install-fix

  1. cmake-staging-install-fix
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

When not passing any CMAKE_INSTALL_PREFIX
  file(INSTALL DESTINATION "/usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Settings/Menus" TYPE FILE FILES
changes to
  file(INSTALL DESTINATION "/usr/local/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Settings/Menus" TYPE FILE FILES
in
  plugins/Ubuntu/Settings/Menus/cmake_install.cmake

I guess the second is probably "more correct" for some definition of correct but since it is not what you're trying to fix, i'd prefer if the invokation without CMAKE_INSTALL_PREFIX behaved the same than without this patch.

review: Needs Fixing

« Back to merge proposal