Code review comment for lp://qastaging/~3v1n0/unity-2d/unity-core-indicators-revisited

Revision history for this message
Aurélien Gâteau (agateau) wrote :

Hi, thanks for your work!

I am a bit stuck on your MR right now as libunity does not build here => no build of unity => can't try it.

In the meantime, you can already fix coding style issues:
- braces for single lines if
- opening braces on the same line as the opening line
- camelCase for all vars and methods

Check the CODING file for more info.

review: Needs Fixing

« Back to merge proposal