Merge lp://qastaging/~3v1n0/unity/fix-load-icon-crash-926658 into lp://qastaging/unity
Status: | Rejected |
---|---|
Rejected by: | Marco Trevisan (Treviño) |
Proposed branch: | lp://qastaging/~3v1n0/unity/fix-load-icon-crash-926658 |
Merge into: | lp://qastaging/unity |
Prerequisite: | lp://qastaging/~3v1n0/unity/barrier-timeout |
Diff against target: |
641 lines (+150/-144) 7 files modified
UnityCore/ModelRowAdaptor.h (+1/-1) dash/LensView.cpp (+40/-5) dash/LensView.h (+4/-0) dash/ResultRendererTile.cpp (+80/-98) dash/ResultRendererTile.h (+1/-2) dash/ResultView.cpp (+21/-32) dash/ResultView.h (+3/-6) |
To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/fix-load-icon-crash-926658 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Needs Fixing | ||
Francis Ginther | Abstain | ||
jenkins (community) | continuous-integration | Needs Fixing | |
Review via email:
|
This proposal supersedes a proposal from 2012-07-20.
Commit message
ResultRendererTile: don't crash in LoadIcon if row.renderer<
Description of the change
In ResultRendererT
The implementation of that depends on dee_model_
So, at this point, even if it would not the best solution, it's better to add a safety check to prevent crashes.
Sorry, but I don't like this one bit, dee_model_get_tag can crash if the passed model is not valid (already unreferenced). IMO guarding against null is not going to help, you'll just push the crash to a different place (in the better case, in worse you'll mask the underlying problem completely and there'll be even more random crashes).