Unity

Merge lp://qastaging/~3v1n0/unity/indicators-tests into lp://qastaging/unity

  1. indicators-tests
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 2134
Proposed branch: lp://qastaging/~3v1n0/unity/indicators-tests
Merge into: lp://qastaging/unity
Prerequisite: lp://qastaging/~3v1n0/unity/dbus-indicators-proxy
Diff against target: 724 lines (+605/-31)
3 files modified
UnityCore/Indicators.cpp (+18/-14)
tests/CMakeLists.txt (+1/-17)
tests/test_indicators.cpp (+586/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/indicators-tests
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+97557@code.qastaging.launchpad.net

Commit message

tests: added gtests for the unity::indicator::Indicators class

Description of the change

tests: added a gtests for the unity::indicator::Indicators class

This was one of the main indicator classes in unitycore because, even if it's abstract (and the only that implements it is DBusIndicators), it has the role to redirect the events from the indicators entries to the panel-service and back.
So, here we're testing the logic of this class, while tests on the real implementation should be added.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Line 160 is pointless. You are asserting that something is empty after you just assigned it to "".

Do we have any AP tests for the indicators? I'm not sure we do.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> Line 160 is pointless. You are asserting that something is empty after you
> just assigned it to "".

Yes, I know, but I added that to be extra-sure that it was true, and making the tests to fail instead :)

> Do we have any AP tests for the indicators? I'm not sure we do.

No, we haven't yet. I would like to introduce some of them, I've already done some introspection work.

Revision history for this message
Tim Penhey (thumper) wrote :

While I still think that some of the tests are too long, I think this is better than no tests :-)

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No proposals found for merge of lp:~3v1n0/unity/dbus-indicators-proxy into lp:unity.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.