Unity

Code review comment for lp://qastaging/~3v1n0/unity/indicators-tests

  1. indicators-tests
  2. Merge into trunk
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> Line 160 is pointless. You are asserting that something is empty after you
> just assigned it to "".

Yes, I know, but I added that to be extra-sure that it was true, and making the tests to fail instead :)

> Do we have any AP tests for the indicators? I'm not sure we do.

No, we haven't yet. I would like to introduce some of them, I've already done some introspection work.

« Back to merge proposal