Unity

Code review comment for lp://qastaging/~3v1n0/unity/lim

  1. lim
  2. Merge into trunk
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

how often is get_indicator_entry_by_id() called? I am really very cautious of creating pipes all over the place...

Also, you should be logging a critical if we're passed an invalid pointer. This means that there is a bug in Unity or someone playing tricks on us.

« Back to merge proposal