Code review comment for lp://qastaging/~3v1n0/unity/lim

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> how often is get_indicator_entry_by_id() called? I am really very cautious of
> creating pipes all over the place...

Every time we get a signal from the unity panel to open a menu, to scroll or to middle-click... So basically on clicks over menus, scrubbing, scrolling or middle-clicking. Plus when the gometries of an entry changes (on added/removed, and when its position on the screen change).
So this mostly happen when there's user interaction.

As said, if you think it's better, we can also just create a temporary file when the service starts, open it and keeping its fd until we stop the panel service... Using that for our pointer-checking work.

Anyway I guess that generally our system really opens a lot of fd's when doing more high-level operations (for DBus for example, but also for more standard things), that we don't care about...

> Also, you should be logging a critical if we're passed an invalid pointer.
> This means that there is a bug in Unity or someone playing tricks on us.

Yes, I agree about that. It was already on my TODO list ;)

« Back to merge proposal