> plugins/unityshell/src/DashView.cpp
std::string form_factor;
Lets give this a sensible default, like:
std::string form_factor("unknown");
Do we really need drag_window_to_monitor?
> tests/autopilot/autopilot/emulators/unity/dash.py
PEP-257 says:
def monitor(self): """The monitor where the dash is."""
> tests/autopilot/autopilot/emulators/unity/panel.py
We try to keep system includes together, so: from time import sleep should be the line below import logging
I'd also prefer that instead of the emulator having its own mouse, the move_mouse_* methods took a mouse parameter.
Same for the other emulators.
There is a lot of duplication in the emulators, but given the need for expediency, I'm ok with this for now.
You don't need: panel_monitor = 0 in the base test case.
You shouldn't need a sleep at the start of a test method.
PanelMenuTests?
Are they coming?
« Back to merge proposal
> plugins/ unityshell/ src/DashView. cpp
std::string form_factor;
Lets give this a sensible default, like:
std::string form_factor( "unknown" );
Do we really need drag_window_ to_monitor?
> tests/autopilot /autopilot/ emulators/ unity/dash. py
PEP-257 says:
def monitor(self):
"""The monitor where the dash is."""
> tests/autopilot /autopilot/ emulators/ unity/panel. py
We try to keep system includes together, so:
from time import sleep
should be the line below
import logging
I'd also prefer that instead of the emulator having its
own mouse, the move_mouse_* methods took a mouse parameter.
Same for the other emulators.
There is a lot of duplication in the emulators, but given
the need for expediency, I'm ok with this for now.
You don't need:
panel_monitor = 0 in the base test case.
You shouldn't need a sleep at the start of a test method.
PanelMenuTests?
Are they coming?