Unity

Code review comment for lp://qastaging/~3v1n0/unity/super-tab-improvements

  1. super-tab-improvements
  2. Merge into trunk
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> 49 - if ((*it)->GetCenter().y + - _icon_size/ 2 < GetGeometry().y)
> 50 + if ((*it)->GetCenter().y - _icon_size / 2 < GetGeometry().y)
> 51 + {
>
> That should test for > 0. In the diff it initially looked like you were
> changing a + to a - :)

What do you mean? You'd prefer to move GetGeometry().y to the left side?
The old code contained a copy&paste typo because there was a "+ -" operator that is just a "-" in fact.

« Back to merge proposal