Code review comment for lp://qastaging/~abone/ubuntu/precise/console-setup/fix-433897

Revision history for this message
Andrey Bondarenko (abone) wrote :

I've tried to remove OPTION=FRAMEBUFFER from init-top/console_setup script. At least it does not break my system. This option was added by Scott James Remnant <email address hidden> in revision 69 on 15th December 2009 with comment "We don't need the initramfs hooks if the initramfs doesn't load the framebuffer or splash screen" Looks like a kind of optimization.

So, I don't mind having console_setup enabled all the time. Another way, if you prefer to save some space in latin locales, is to creaate separate option for console-setup, and enable it regardles of framebuffer usage. For example it can be enabled if /etc/default/locale contains some non-latin locale or /etc/default/console-setup have some "non-default" font setup.

My patch also contains upstart job for console-setup. This job, in my opinion, should be enabled anyway.

Waiting for your feedback.

« Back to merge proposal