Code review comment for lp://qastaging/~abone/ubuntu/precise/console-setup/fix-433897

Revision history for this message
Colin Watson (cjwatson) wrote :

After some thought, I agree that this Upstart job is the right thing to add, and I'm going to apply this to quantal. Thanks!

I am much less convinced by the proposal to remove OPTION=FRAMEBUFFER (and still less by the proposal to force FRAMEBUFFER=y when splash is enabled; I agree with Oliver on that). I also don't think that creating a separate option for it is the right answer. If the framebuffer isn't enabled for some other reason, then the console-setup script should not need to run in the initramfs at all (except in the case of a panic, which is handled); the fact that this shouldn't be needed is what OPTION=FRAMEBUFFER expresses. It should be sufficient for the corresponding code to run from udev rules and Upstart jobs.

Therefore, if the udev rules and Upstart jobs aren't working properly when there is no framebuffer code in the initramfs, that is what needs to be debugged. I believe this ought to be possible without running console-setup code in the initramfs.

review: Needs Fixing

« Back to merge proposal