Code review comment for lp://qastaging/~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> In a previous comment, I was suggesting to remove the "--block-open-external-
> urls" command-line switch, but I’m seeing what I assume is a leftover in
> src/app/webcontainer/webapp-container.cpp.

I think your previous comment (that was addressed) was more about the "doFilterWebappUrlPatterns" flag which was now updated & cleaned w/ a env var approach,

I couldn't find references of a comment about the "--block" flag,

« Back to merge proposal