Mir

Code review comment for lp://qastaging/~afrantzis/mir/consume-only-not-rendered-buffers

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> I think this is a slightly awkward way to express what I proposed (without
> using time measurement):
> https://code.launchpad.net/~vanvugt/mir/judder/+merge/216694
>
> I'd prefer all future work avoided the unreliability of time measurement.
> Because with some careful planning you can avoid it.

The two proposal are not equivalent. As noted in https://code.launchpad.net/~vanvugt/mir/judder/+merge/216694, the judder branch "reintroduces eglSwapBuffers() blocking for buffers that are not rendered by the real compositors (i.e. for surfaces that are either occluded or off screen). That is, it only keeps eglSwapBuffers() running when all monitors are off."

This proposal keeps eglSwapBuffers() running in all cases (monitors off, surface occluded, surface off-screen).

« Back to merge proposal