Mir

Code review comment for lp://qastaging/~afrantzis/mir/fix-1335741-surface-destruction-after-teardown

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I don't think this fix is related to lp:1335741. I also think it can be simplified as above.

lp:1335741 reports an error during the test, not during teardown and can be "fixed" by adding the following line to the start of client_can_query_current_orientation:

    EXPECT_FALSE(wait_for_event(mir_event_type_orientation, std::chrono::milliseconds(1)));

That isn't a *good* fix but it does strongly suggests that the problem there is with setup not teardown.

So, I suggest we should break the association with lp:1335741 and then land this (or something equivalent).

review: Needs Fixing

« Back to merge proposal