Code review comment for lp://qastaging/~afrantzis/mir/fix-1441620-simple-dispatch-thread-self-destruction-test

> Another option would be to abort instead of detaching the thread; that's
> implemented here: https://code.launchpad.net/~raof/mir/remove-eventloop-self-
> immolation/+merge/255767

I was under the impression that self-destruction was a feature we needed to support (hence the test). If we don't need it, I am fine with dropping it/making it an error like you suggest.

> Rather than passing in a reference to a promise, would it make more sense to
> have a method
> std::shared_future<void> shutdown_notifier()
> and have ~SimpleDispatchThread set_value_at_thread_exit() in the case of
> destruction-from-eventloop-thread?

Unfortunately g++ 4.9 doesn't support set_*_at_thread_exit.