Mir

Code review comment for lp://qastaging/~afrantzis/mir/mir-client-ensure-global-symbol-resolution

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > Wouldn't it be as easy (and have mess in fewer places) for platform-api to
> call dlopen() directly?
>
> That's another option, but:
>
> 1. platform-api (or wherever this ends up in) will need to contain the logic
> to load the correct libmirserver.so.X library, which is not as straightforward
> as doing it in mirclient (since we know our soname)
> 2. it exposes the mechanism by which this is performed which platform-api
> doesn't really care about
> 3. it will not be as easy to reuse the code in other similar cases or move the
> point of application

OK then

review: Approve

« Back to merge proposal