Mir

Code review comment for lp://qastaging/~afrantzis/mir/texture-bindable

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

16 + ${PROJECT_SOURCE_DIR}/src/renderers/gl/include

"The definition of TextureBindable will eventually be made public (e.g. shipped in a mir-renderer-gl-dev package), so I have made it accessible from most of the non-core codebase (tests and examples)."

I'd be happier with putting the header under include and making it public than having this "temporary" solution.

If we do need a temporary location for pre-public files I'd prefer a name like "${PROJECT_SOURCE_DIR}/src/pre-public-include" to burying it whatever part of the source tree is publishing that specific file.

review: Needs Fixing

« Back to merge proposal