unity-2d

Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash

  1. desktop-dash
  2. Merge into natty
Revision history for this message
Florian Boucault (fboucault) wrote :

In places/app/dashdeclarativeview.h:

Property dashState should not contain 'dash' in its name (similar to the 'active' property which is not named 'dashActive'). All methods (getter, setter, signal) should be renamed accordingly.

review: Needs Fixing (code)

« Back to merge proposal