Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash

Revision history for this message
Florian Boucault (fboucault) wrote :

> DashDeclarativeView::onWorkAreaResized(int screen)
>
> should take into account other states than just 'FullScreenDash'.

If the available work area's size becomes "close enough" to the size of dash in 'desktop' state then the dash should take all the width of the screen and drop its window borders and resizing handle (similar to what happens in 'fullscreen' state).

To ease that implementation and make the code cleaner, the logic to determine if the size of the dash is "close enough" should not be part of DashDeclarativeView::setActive but factored out in a separate method.
In this merge request that code is incomplete at the moment as it only checks the resolution of the screen against a static resolution DASH_MIN_SCREEN_WIDTH/DASH_MIN_SCREEN_HEIGHT whereas it should:
 - determine whether or not the screen resolution is one of a netbook
 - if yes, then compare the size of the dash in 'desktop' state and the size of the available area and if the dash takes "most" of the available area then behave as if it were in 'fullscreen' state

Let's discuss this very soon in order to make it crystal clear.

review: Needs Fixing (code)

« Back to merge proposal