Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash

Revision history for this message
Florian Boucault (fboucault) wrote :

places/dash.qml:

- 'shortcutsButton' should be part of the home page as it is never used in the places.
- 'expanded'/'collapsed' state management is overly complicated: a binding of dashView.dashState would suffice:

Binding {
    target: dashView
    property: "dashState"
    value: THE_RIGHT_VALUE (taken from updateDashState)
}

Though this will not be necessary as this should move to Home.qml as well as it is the only place where collapsed/expanded is relevant

review: Needs Fixing (code)

« Back to merge proposal