Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash
Revision history for this message
| Aurélien Gâteau (agateau) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> In places/
>
> Property dashState should not contain 'dash' in its name (similar to the
> 'active' property which is not named 'dashActive'). All methods (getter,
> setter, signal) should be renamed accordingly.
I disagree: "state" is too generic. I agree "dash" is not the best prefix though (same for the enums). What about renaming the whole "dashState" to "appearance" or "formFactor"?