> > In places/app/dashdeclarativeview.h:
> >
> > Property dashState should not contain 'dash' in its name (similar to the
> > 'active' property which is not named 'dashActive'). All methods (getter,
> > setter, signal) should be renamed accordingly.
>
> I disagree: "state" is too generic. I agree "dash" is not the best prefix
> though (same for the enums). What about renaming the whole "dashState" to
> "appearance" or "formFactor"?
> > In places/ app/dashdeclara tiveview. h:
> >
> > Property dashState should not contain 'dash' in its name (similar to the
> > 'active' property which is not named 'dashActive'). All methods (getter,
> > setter, signal) should be renamed accordingly.
>
> I disagree: "state" is too generic. I agree "dash" is not the best prefix
> though (same for the enums). What about renaming the whole "dashState" to
> "appearance" or "formFactor"?
How about 'mode' or 'layout'? or 'layoutMode'?