Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash

Revision history for this message
Aurélien Gâteau (agateau) wrote :

> > > places/artwork/desktop_dash.sci
> > > places/artwork/desktop_dash_background.png
> > >
> > > Please name the sci identically to the png file.
> >
> > Oups. I agree.
> >
> > > Also I think it would be
> > > clearer to name it 'border' or 'handle' rather than 'background'
> >
> > I choose background because the image is also used for the background of the
> > Dash. I don't have any strong opinion on this though: pick which name you
> > prefer.
>
> I had not noticed it was used as background. That probably conflicts with the
> GnomeBackground being drawn below with a color blended into it. Let's discuss
> this.

Right now what happens is that GnomeBackground is not shown when in desktop mode, so it does not really conflict. That may not be what the designer had in mind though.

« Back to merge proposal