Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash

> places/dash.qml:
>
> - 'shortcutsButton' should be part of the home page as it is never used in the
> places.

This cannot be done because the home page is hidden when the shortcut button is shown.

> - 'expanded'/'collapsed' state management is overly complicated: a binding of
> dashView.dashState would suffice:
>
> Binding {
> target: dashView
> property: "dashState"
> value: THE_RIGHT_VALUE (taken from updateDashState)
> }
>
> Though this will not be necessary as this should move to Home.qml as well as
> it is the only place where collapsed/expanded is relevant

Just tried this approach and could not get it to work: it caused a loop in the binding as the computation for THE_RIGHT_VALUE needs to access dashState (to avoid changing it when we are in fullscreen mode)

>> places/artwork/desktop_dash.sci
>> places/artwork/desktop_dash_background.png
>>
>> Please name the sci identically to the png file.

> Oups. I agree.

Renamed desktop_dash.sci to desktop_dash_background.sci for now.