Code review comment for lp://qastaging/~agateau/unity-2d/desktop-dash

Revision history for this message
Florian Boucault (fboucault) wrote :

> > > > Looks like:
> > > >
> > > > Binding {
> > > > target: dashView
> > > > property: "expanded"
> > > > value: (currentPage && currentPage.expanded != undefined) ?
> > > > currentPage.expanded : true
> > > > }
> > > >
> > > >
> > > > could be moved from places/dash.qml to places/Home.qml
> > >
> > > The binding depends on currentPage, which is in dash.qml, so what would be
> > the
> > > gain of moving it?
> >
> > Moving it to places/Home.qml also means using a reference to the home page
> > instead of 'currentPage'. The point here is that the behaviour is specific
> to
> > the home page.
>
> We need 'currentPage' to be able to turn expanded on when switching to the
> place view.

You are right. Sorry for overlooking this.

« Back to merge proposal