Merge lp://qastaging/~agateau/unity-2d/unity-core into lp://qastaging/unity-2d/3.0
Status: | Superseded |
---|---|
Proposed branch: | lp://qastaging/~agateau/unity-2d/unity-core |
Merge into: | lp://qastaging/unity-2d/3.0 |
Prerequisite: | lp://qastaging/~agateau/unity-2d/gtk3 |
Diff against target: |
3681 lines (+1487/-1601) 46 files modified
CMakeLists.txt (+0/-33) debian/20_ubuntu-2d-gconf-default (+0/-8) debian/20_ubuntu-2d-gconf-mandatory (+0/-1) debian/changelog (+49/-6) debian/control (+11/-10) debian/gconf/ubuntu-2d.default.path (+2/-2) debian/gconf/ubuntu-2d.mandatory.path (+2/-2) debian/unity-2d-panel.install (+0/-2) debian/unity-2d.gconf-defaults (+4/-0) debian/unity-2d.install (+2/-4) debian/unity-2d.postinst (+12/-15) debian/unity-2d.postrm (+11/-14) debian/unity-2d.preinst (+16/-0) libunity-2d-private/Unity2d/CMakeLists.txt (+0/-5) libunity-2d-private/src/CMakeLists.txt (+1/-0) libunity-2d-private/src/debug.cpp (+23/-0) libunity-2d-private/src/debug_p.h (+6/-0) libunity-2d-private/src/unity2dapplication.cpp (+0/-25) panel/CMakeLists.txt (+3/-5) panel/app/CMakeLists.txt (+1/-0) panel/app/main.cpp (+4/-0) panel/app/panelmanager.cpp (+32/-46) panel/app/panelmanager.h (+4/-0) panel/applets/CMakeLists.txt (+10/-27) panel/applets/appname/appnameapplet.cpp (+5/-10) panel/applets/appname/appnameapplet.h (+3/-1) panel/applets/appname/com.canonical.AppMenu.Registrar.xml (+0/-82) panel/applets/appname/menubarwidget.cpp (+78/-292) panel/applets/appname/menubarwidget.h (+25/-72) panel/applets/appname/registrar.cpp (+0/-138) panel/applets/appname/registrar.h (+0/-85) panel/applets/common/fakecairo.h (+125/-0) panel/applets/common/indicatorentrywidget.cpp (+388/-0) panel/applets/common/indicatorentrywidget.h (+81/-0) panel/applets/common/indicatorsmanager.cpp (+176/-0) panel/applets/common/indicatorsmanager.h (+70/-0) panel/applets/common/indicatorwidget.cpp (+53/-0) panel/applets/common/indicatorwidget.h (+52/-0) panel/applets/common/panelstyle.cpp (+175/-0) panel/applets/common/panelstyle.h (+59/-0) panel/applets/indicator-config.h.in (+0/-7) panel/applets/indicator/indicator.c (+0/-526) panel/applets/indicator/indicator.h (+0/-45) panel/applets/indicator/indicatorapplet.cpp (+0/-77) panel/applets/indicator/indicatorapplet.h (+0/-57) places/HomeShortcuts.qml (+4/-4) |
To merge this branch: | bzr merge lp://qastaging/~agateau/unity-2d/unity-core |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Florian Boucault (community) | Needs Fixing | ||
Tim Penhey | Pending | ||
Review via email:
|
This proposal supersedes a proposal from 2011-07-05.
This proposal has been superseded by a proposal from 2011-07-27.
Description of the change
This branch is an heavy refactor of unity-2d-panel to use the new indicator-
(resubmitted to mark lp:~agateau/unity-2d/gtk3 as a prerequisite branch)
Unmerged revisions
- 687. By Aurélien Gâteau
-
[panel] Make sure indicators are present on hotplugged monitor
IndicatorsManager should not be shared among panels, otherwise when a new
monitor is plugged after unity-2d-panel startup, we don't get any indicators as
no on_object_added() signal is emitted. - 686. By Aurélien Gâteau
-
Sync with unity-2d/4.0
- 685. By Aurélien Gâteau
-
[panel] Empty commit to close bugs
- 684. By Aurélien Gâteau
-
Merge unity-2d/4.0 in
- 683. By Aurélien Gâteau
-
Sync with gtk3
- 682. By Aurélien Gâteau
-
Remove forgotten FIXME comment
- 681. By Aurélien Gâteau
-
[build] Fix build with libunity-core 4.4
UnityCore.h has been removed
- 680. By Aurélien Gâteau
-
Synced with gtk3 branch
- 679. By Aurélien Gâteau
-
Cleanup
- 678. By Aurélien Gâteau
-
Merged gtk3 branch
Hi Aurélien,
I notice you have a GConnector class. It covers a very similar area to Neil's /code.launchpad .net/~njpatel/ unity/nicer- glib-signals/ +merge/ 67439
latest work -
https:/
I also notice you aren't using namespaces for your top level classes - like
the GConnector. Have you considered using one?
A slight niggle, <string> is in the C++ standard library, not the STL (they
don't say we work for pedantical for nothing).
Redeclaring nux::Color is a dangerous thing. Slightly convoluted due to the
actual nux Color being nux::color::Color, which is then used in the nux
namespace. That is probably the only reason you are not getting linker errors
with this.