Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/add-manual-tests-001 into lp://qastaging/music-app

add-manual-tests-001
Merge into trunk

Proposed by Andrew Hayzen on 2015-09-23

Status:	Superseded
Proposed branch:	lp://qastaging/~ahayzen/music-app/add-manual-tests-001
Merge into:	lp://qastaging/music-app
Diff against target:	344 lines (+306/-0) 6 files modified debian/changelog (+3/-0) tests/manual/music_app/jobs/external.pxu (+55/-0) tests/manual/music_app/jobs/library.pxu (+124/-0) tests/manual/music_app/jobs/playlists.pxu (+66/-0) tests/manual/music_app/jobs/queue.pxu (+37/-0) tests/manual/music_app/jobs/recent.pxu (+21/-0)
To merge this branch:	bzr merge lp://qastaging/~ahayzen/music-app/add-manual-tests-001
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jenkins Bot	continuous-integration		Needs Fixing on 2015-11-16
Nicholas Skaggs (community)		2015-09-23	Needs Fixing on 2015-09-30
Victor Thompson		2015-09-23	Approve on 2015-09-26
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2015-09-25
Review via email: mp+272050@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2015-12-16.

Commit message

* Add manual tests in checkbox format to repo

Description of the change

* Add manual tests in checkbox format to repo

This has been directly copied from the old manual tests [0]

Note that the durations are all 600 and that any notes/prerequisites I've currently put in the 1.

0 - http://pad.ubuntu.com/MusicAppManualTesting

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-09-23:

#

PASSED: Continuous integration, rev:918
http://91.189.93.70:8080/job/music-app-ci/1381/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/233

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1381/rebuild

review: Approve (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2015-09-24:

#

I noticed a few small things, but otherwise this lgtm.

review: Needs Fixing

lp://qastaging/~ahayzen/music-app/add-manual-tests-001 updated on 2015-09-25

919. By Andrew Hayzen on 2015-09-25: * Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2015-09-25:

#

* Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation

Please retest :-)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-09-25:

#

PASSED: Continuous integration, rev:919
http://91.189.93.70:8080/job/music-app-ci/1383/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/235

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1383/rebuild

review: Approve (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2015-09-26:

#

This looks good to me. I'd like to get balloon's final opinion prior to merging, however.

review: Approve

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-09-29:

#

These are fine, but will need a provider and folder layout to make them plug and play. I'll bundle them and try them before providing a diff.

It's not crystal clear if we do want to include the provider in here, so perhaps these will be a-ok.

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-09-29:

#

Prefix the tests file names with 'music-'

You are missing a colon
s/_description/_description:/g

Still deciding on the provider / no provider bit.

review: Needs Fixing

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-09-30:

#

Ohh my, I didn't notice the embedded links for results! Those won't play nice on the phone. Not sure what to do with them right now, other than to ensure there is text to go along with them.

It is possible to embed the image, but we are limited to text because of how QA stores the tests and processes them. It may be possible to embed them anyway though :p

review: Needs Fixing

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-10-01:

#

Leaving a note on how the images would have to be embedded. We would have to change the job type, as well as package the images and reference them.

use qml type of job
include $your_file.png in the 'data' dir of the provider
reference it as Qt.resolvedUrl("$your_file.png")

Revision history for this message

Victor Thompson (vthompson) wrote on 2015-11-07:

#

I'm going to hold off on reviewing this for now. Andrew, could you look into balloon's concerns?

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2015-11-16:

#

FAILED: Continuous integration, rev:919
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/9/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/142/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/9/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

919. By Andrew Hayzen on 2015-09-25: * Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation
918. By Andrew Hayzen on 2015-09-23: * Merge of trunk
* Add changelog text
917. By Andrew Hayzen on 2015-09-22: * Add manual tests in checkbox format to repo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Andrew Hayzen

Music App Developers