Ubuntu Music App

Merge lp://qastaging/~nskaggs/music-app/manual-tests into lp://qastaging/music-app

  1. manual-tests
  2. Merge into trunk
Proposed by Nicholas Skaggs
Status: Merged
Approved by: Victor Thompson
Approved revision: 956
Merged at revision: 959
Proposed branch: lp://qastaging/~nskaggs/music-app/manual-tests
Merge into: lp://qastaging/music-app
Diff against target: 427 lines (+364/-0)
11 files modified
tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-external.pxu (+62/-0)
tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-library.pxu (+131/-0)
tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-playlists.pxu (+73/-0)
tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-queue.pxu (+44/-0)
tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-recent.pxu (+28/-0)
tests/manual/2015.com.ubuntu.music:music-tests/manage.py (+21/-0)
tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-external.whitelist (+1/-0)
tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-library.whitelist (+1/-0)
tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-playlists.whitelist (+1/-0)
tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-queue.whitelist (+1/-0)
tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-recent.whitelist (+1/-0)
To merge this branch: bzr merge lp://qastaging/~nskaggs/music-app/manual-tests
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Andrew Hayzen Approve
Nicholas Skaggs Pending
Ubuntu Phone Apps Jenkins Bot continuous-integration Pending
Review via email: mp+280777@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-09-23.

Commit message

* Add manual tests in checkbox format to repo

Description of the change

* Add manual tests in checkbox format to repo

This has been directly copied from the old manual tests [0]

Note that the durations are all 600 and that any notes/prerequisites I've currently put in the 1.

0 - http://pad.ubuntu.com/MusicAppManualTesting

---

Andrew, this is the version that shipped with Pilot. The ideas about inline images, etc, still stands. Something to take more about with the checkbox team if we can't get it to work. For now however, these work well.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:918
http://91.189.93.70:8080/job/music-app-ci/1381/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/233

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1381/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

I noticed a few small things, but otherwise this lgtm.

review: Needs Fixing
Revision history for this message
Andrew Hayzen (ahayzen) wrote : Posted in a previous version of this proposal

* Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation

Please retest :-)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:919
http://91.189.93.70:8080/job/music-app-ci/1383/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/235

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1383/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

This looks good to me. I'd like to get balloon's final opinion prior to merging, however.

review: Approve
Revision history for this message
Nicholas Skaggs (nskaggs) wrote : Posted in a previous version of this proposal

These are fine, but will need a provider and folder layout to make them plug and play. I'll bundle them and try them before providing a diff.

It's not crystal clear if we do want to include the provider in here, so perhaps these will be a-ok.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote : Posted in a previous version of this proposal

Prefix the tests file names with 'music-'

You are missing a colon
s/_description/_description:/g

Still deciding on the provider / no provider bit.

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote : Posted in a previous version of this proposal

Ohh my, I didn't notice the embedded links for results! Those won't play nice on the phone. Not sure what to do with them right now, other than to ensure there is text to go along with them.

It is possible to embed the image, but we are limited to text because of how QA stores the tests and processes them. It may be possible to embed them anyway though :p

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote : Posted in a previous version of this proposal

Leaving a note on how the images would have to be embedded. We would have to change the job type, as well as package the images and reference them.

use qml type of job
include $your_file.png in the 'data' dir of the provider
reference it as Qt.resolvedUrl("$your_file.png")

Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

I'm going to hold off on reviewing this for now. Andrew, could you look into balloon's concerns?

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:919
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/9/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/142/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:956
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/30/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/261/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/30/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM! As discussed for now we'll merge this with the image links so that Pilot can be 'in-sync' :-)

review: Approve
Revision history for this message
Victor Thompson (vthompson) wrote :

Lgtm!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches