Code review comment for lp://qastaging/~ahs3/cloud-live/natty-upgrade

Revision history for this message
Al Stone (ahs3) wrote :

On 08/01/2011 02:15 PM, David Medberry wrote:
> Review: Approve
> Looked through (long) diff and saw nothing troubling. Finally figured out that you were including the config ppa (which was confusing me to no end.) Once I grokked that, built and tested. Go for it.
>
> Process check: I selected "Review: Approve" in the web gui. Am I supposed to discuss in email first?

Discussion would be driven by your level of approval/disapproval, as
far as I know.

Sorry I didn't make using the config PPA clearer :(. But yeah, it is
needed.

Maybe we should add some sort of README somewhere...

--
Ciao,
al
----------------------------------------------------------------------
Al Stone
OEM Services
Canonical USA
E-mail: <email address hidden>
----------------------------------------------------------------------

« Back to merge proposal