Code review comment for lp://qastaging/~alan-griffiths/compiz-core/refactor-Display-from-PrivateScreen

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> 3746 + // >>>>>>>>>> WEIRD STUFF >>>>>>>>>>
> 3747 + // TODO - unimplemented and unused?
> 3748 + void updatePassiveGrabs ();
>
> It has been replaced by updatePassiveKeyGrabs and can be removed
>
> 3749 + // TODO - unimplemented and unused?
> 3750 + bool createFailed ();
>
> We should replace this with exceptions.
>
> 3751 + // TODO - unused?
> 3752 + std::map<CompString, CompPrivate> valueMap;
>
> 99% sure that ValueHolder replaced this one (although we need to convert
> ValueHolder from being a singleton to being an interface)(
>
> 3753 + // TODO - unused?
> 3754 + xcb_connection_t *connection;
>
> Yep, it can go too (although I really would love to use xcb at some point in
> the future)
>
> 3755 + // TODO - unused?
> 3756 + XRectangle lastViewport;
>
> Can also go
>
> 3757 + // <<<<<<<<<< WEIRD STUFF <<<<<<<<<<
> 3758 +

Thanks Sam.

« Back to merge proposal