Code review comment for lp://qastaging/~alan-griffiths/compiz-core/refactor-Display-from-PrivateScreen

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > Where I'm aiming for is a CompScreen interface and an implementation that
> > contains classes to manage individual functional areas. This commit is a
> step
> > in that direction.
>
> +1
>
> I'd like for us all to keep this design goal in mind. CompWindow and
> CompScreen are monstrosities - even if we can specify a number of different
> interfaces they provide, this is far better for testing and refactoring then
> coding to CompScreen and friends.

Having done this exercise once I think I can get to the end result with less scary diffs. I'll create another branch and submit that.

review: Disapprove

« Back to merge proposal