OK on the first issue. Although "helps with an immediate problem without getting in the way of further enhancements" is a benefit that's also contradictory to good engineering: Everything you write should ideally have multiple uses so that functionality grows exponentially faster than the code size. We're failing on that part.
So Abstain except for Cemil's comment...
I agree that mir_surface_spec_attach is not an adequate name on first glance. You should be able to roughly figure out the purpose from the function name.
OK on the first issue. Although "helps with an immediate problem without getting in the way of further enhancements" is a benefit that's also contradictory to good engineering: Everything you write should ideally have multiple uses so that functionality grows exponentially faster than the code size. We're failing on that part.
So Abstain except for Cemil's comment... spec_attach is not an adequate name on first glance. You should be able to roughly figure out the purpose from the function name.
I agree that mir_surface_